feat: initial code actions backend for Linter service #139
Conversation
aminya
commented
Mar 19, 2021
•
aminya
commented
- Moves the old atom-ide-diagnostics code to a separate adapter
- Adds initial code actions support for the Linter package -> The packages themselves have not implemented this yet
aminya
force-pushed
the
code-actions
branch
2 times, most recently
from
09ba7e5
to
ea2a300
Compare
| linterName: diagnostic.source, | ||
| severity: lsSeverityToV2MessageSeverity(diagnostic.severity ?? DiagnosticSeverity.Error), | ||
| // BLOCKED: on steelbrain/linter#1722 | ||
| solutions: undefined, |
There was a problem hiding this comment.
Not sure how to provide solutions from Ls.Diagnostic. We need to first update Linter package
|
Can you show us a screenshot of the UI? are there new commands like "show solutions under cursor" or "apply solutions" or something? |
This is the backend adapter for code actions. The UI isn't implemented yet. We need to fix these two issues to support the UI as well |
Co-Authored-By: Lev Chelyadinov <illright@users.noreply.github.com>
Co-Authored-By: Lev Chelyadinov <illright@users.noreply.github.com>
Co-Authored-By: Lev Chelyadinov <illright@users.noreply.github.com>
Co-Authored-By: Lev Chelyadinov <illright@users.noreply.github.com>
Co-Authored-By: Lev Chelyadinov <15035286+illright@users.noreply.github.com>
Co-Authored-By: Lev Chelyadinov <15035286+illright@users.noreply.github.com>
extend form Linter
Co-Authored-By: Lev Chelyadinov <illright@users.noreply.github.com>
There was a problem hiding this comment.
This can be merged as of its current state because it is backward compatible and the changes are tested. We should update it later again once Linter and Linter-ui-default actually implemented the UI for this. We can't do anything else here for now.
Because the changes edit multiple files, we should merge this first before we can fix #156
aminya
changed the title
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
